Skip to content

Fix room state events not actionable on tap#6619

Open
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
bxdxnn:fix/state-events-callbacks
Open

Fix room state events not actionable on tap#6619
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
bxdxnn:fix/state-events-callbacks

Conversation

@bxdxnn
Copy link
Copy Markdown
Contributor

@bxdxnn bxdxnn commented Apr 18, 2026

Content

Add callbacks to room state events.
If you tap on e.g. a membership event, a profile bottom sheet of the target user (i.e. if a user gets invited, "target user" is the one who gets invited, etc.) will open.
If you tap on any other room state event, e.g. topic change or the room creation, the room's profile will open.

Motivation and context

When tapping on room state events, nothing happens yet there's a ripple.

Tests

  • Test that tapping on a membership event opens a profile bottom sheet of the target user
  • Test that tap on any other room state event opens the room's profile

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bxdxnn bxdxnn requested a review from a team as a code owner April 18, 2026 20:14
@bxdxnn bxdxnn requested review from ganfra and removed request for a team April 18, 2026 20:14
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 18, 2026
@bxdxnn bxdxnn force-pushed the fix/state-events-callbacks branch from 80538c4 to 2f778c3 Compare April 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants